Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add diagnosis memory leak guide #4590

Closed
wants to merge 8 commits into from

Conversation

tony-go
Copy link
Member

@tony-go tony-go commented May 5, 2022

Hi Node Familly 👋

Context

The Diagnostic Working Group started an initiative to re-assess the diagnostics tools list.

I start to work around the --trace-gc flag:

But something is missing... 😞

If you take a look at the diagnostic tooling support tiers, you'll see that:

The tool must have a guide or other documentation in the Node.js GitHub organization or website;

Added

I propose to add a new guide to the existing collection 🆕.

The guide is about how could we use built-in tools to diagnose memory leaks.

Here is a list of topics I hope this guide will help on:

  • basics of garbage collection
  • what is the purpose of --trace-gc? and how could we interpret the output?
  • how to perform heap snapshot?
  • how to compare heap snapshot with Chrome dev tool?

⚠️ DISCLAIMER: I voluntarily simplify garbage collection concepts (that I didn't master myself). I don't know If it's a good idea or not, please share your thoughts on that. Note that my initial intention was to provide an introductory guide more than a deep dive.

Concern

  • I'm not sure about how should we handle images and gifs (location, size ...)

@tony-go
Copy link
Member Author

tony-go commented May 5, 2022

cc @nodejs/diagnostics

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the initial idea of the diagnostics working group was to add those guides in https://github.com/nodejs/diagnostics to then elaborate a long guide to nodejs.org.

I feel we need to discuss it. What do you think?

I recommend you add it to the next diag-agenda. cc: @nodejs/diagnostics

EDIT1: I mean, I feel this guide would fit perfectly in: https://github.com/nodejs/diagnostics/tree/main/documentation/memory

@tony-go
Copy link
Member Author

tony-go commented May 10, 2022

Hey @RafaelGSS 👋

Sorry, I was off the past week so I didn't answer quickly.

I think the initial idea of the diagnostics working group was to add those guides in https://github.com/nodejs/diagnostics to then elaborate a long guide to nodejs.org.

I feel we need to discuss it. What do you think?

I recommend you add it to the next diag-agenda. cc: @nodejs/diagnostics

This issue is still in the agenda we could discuss it at the next meeting 🙌 My only concern about keeping stuff in diag repo is that visibility/accessibility is limited. I'd like to expose each piece of the puzzle as soon as it's ready.

@tony-go
Copy link
Member Author

tony-go commented Jun 7, 2022

As discussed in the last diagnostics WG meeting, we'll close this issue and merge the content into the diagnostic repository.

@tony-go tony-go closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants