chore(learn): small update #6132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
approved these changes
Nov 21, 2023
|
Just one things to do before merge, just verify grammar. yep I'm dysorthographic |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
canerakdas
reviewed
Nov 21, 2023
ovflowd
reviewed
Nov 21, 2023
ovflowd
reviewed
Nov 21, 2023
pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md
Outdated
Show resolved
Hide resolved
ovflowd
reviewed
Nov 21, 2023
pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md
Outdated
Show resolved
Hide resolved
mikeesto
reviewed
Nov 21, 2023
pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md
Outdated
Show resolved
Hide resolved
pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md
Outdated
Show resolved
Hide resolved
bmuenzenmeyer
requested changes
Nov 22, 2023
There was a problem hiding this comment.
overall I appreciate the attention to detail to improve the docs - thanks @AugustinMauroy
a couple of suggestions applied
pages/en/learn/command-line/output-to-the-command-line-using-nodejs.md
Outdated
Show resolved
Hide resolved
pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md
Outdated
Show resolved
Hide resolved
aymen94
approved these changes
Nov 23, 2023
…from-nodejs.md Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
…odejs.md Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
bmuenzenmeyer
approved these changes
Nov 24, 2023
github-actions
bot
removed
the
github_actions:pull-request
pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md
Outdated
Show resolved
Hide resolved
…d-line.md Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
small modification on learn section to make it fairer and more up-to-date. I test all code
node:for internal modules.Validation
Related Issues
No related issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.