fix: fixes sentry errors on 404's pages #6144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
force-pushed
the
meta/test-removing-try/catch
branch
from
0792392 to
de2e84f
Compare
ovflowd
changed the title
ovflowd
added
bug
infrastructure
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Nov 27, 2023
Actually, I forgot these changes there. I should remove the patch. |
ovflowd
force-pushed
the
meta/test-removing-try/catch
branch
2 times, most recently
from
331d328 to
35a4e02
Compare
aymen94
approved these changes
Nov 28, 2023
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
force-pushed
the
meta/test-removing-try/catch
branch
from
35a4e02 to
6dcdd51
Compare
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes our Sentry's Server Component Errors fro
/[locale]/by making the Not Found Page client-only.This PR also removes the CPU Profiling Sentry Extension as it was mostly not being used.
The Sentry issue (internally) is: https://nodejs-org.sentry.io/issues/4614002695/events/ae345ce869cb4a7582e925bc7d1958be/
Validation
Deploy this branch preview and analyse on Sentry releases tab (https://nodejs-org.sentry.io/releases/?project=4506191307735040&statsPeriod=1h) that this issue is indeed not re-ocurring.
Related Issues
useamannn/next-intl#614