Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove reference to outdated examples #6851

Merged
merged 1 commit into from
Jul 6, 2024
Merged

chore: remove reference to outdated examples #6851

merged 1 commit into from
Jul 6, 2024

Conversation

RedYetiDev
Copy link
Member

Description

This PR removes the reference to the outdated example repository, as in its current state, it may confuse users more than help them.

Related Issues

nodejs/admin#883 discusses archiving the repository, and this is the only actively maintained link to the repository.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@RedYetiDev RedYetiDev requested a review from a team as a code owner June 19, 2024 22:20
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 5, 2024 5:57pm

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking until nodejs/admin#883 is resolved

@RedYetiDev
Copy link
Member Author

blocking until nodejs/admin#883 is resolved

Thanks! I wanted this blocked until that's resolved anyway, but I wanted to put it in the works to make sure it's okay dev-wise

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now unblocked due to the resolution of the other issue - but we wont merge until we solidify monorepo work

@bmuenzenmeyer
Copy link
Collaborator

This PR will need to be rebased or recreated now that #6850 merged.

@RedYetiDev
Copy link
Member Author

Done!

Copy link
Contributor

github-actions bot commented Jul 6, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 95 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Jul 6, 2024

Unit Test Coverage Report

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.243s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@mikeesto mikeesto added this pull request to the merge queue Jul 6, 2024
Merged via the queue into nodejs:main with commit 9ffde9d Jul 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants