Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream WG meeting - September 2017 #309

Closed
mcollina opened this issue Aug 26, 2017 · 14 comments
Closed

Stream WG meeting - September 2017 #309

mcollina opened this issue Aug 26, 2017 · 14 comments

Comments

@mcollina
Copy link
Member

mcollina commented Aug 26, 2017

Hi Folks

Given our bimonthly meetings, it's time we start planning when we want to run the next streams-wg meeting :).

Agenda:

Here is a doodle: https://doodle.com/poll/ydqhpfc3tksiqr4t

The meeting will take place over hangouts (links to follow) on Tuesday 12th of September at 16:00 GMT.

London time: 17:00
Paris time: 18:00
Portland time: 9:00

-- I hope the times are right. Please check.

Watch at: http://youtu.be/pzHK1iJVGic

cc @jessicaquynh @jasnell.

@yoshuawuyts
Copy link

@mcollina replied! - could you ping people once a date has been decided? Thanks!

Also cc/ @nodejs/streams

@lrlna
Copy link
Contributor

lrlna commented Aug 26, 2017 via email

@mcollina
Copy link
Member Author

mcollina commented Sep 2, 2017

Based on the doodle responses, the meeting will take place Tuesday 12th of September at 16:00 GMT.

I can send a calendar invite, and will ping again one or two days prior to the meeting!

@lrlna
Copy link
Contributor

lrlna commented Sep 2, 2017 via email

@mcollina
Copy link
Member Author

@mcollina
Copy link
Member Author

cc @jessicaquynh?

@sonewman
Copy link
Contributor

can i join?

@mcollina
Copy link
Member Author

@sonewman yes!!!! Come in!

@mcollina
Copy link
Member Author

PR to add the Error: nodejs/node#15042

@sonewman
Copy link
Contributor

@mcollina sorry I didn't have so much to contribute, I will have to spend sometime familiarising myself with the code again before the next meeting!

@mcollina
Copy link
Member Author

mcollina commented Sep 12, 2017

Here are my notes (feel free to edit)

Status of on the use of _readableState and _writableState in core

Hoping for a vote in the next TSC. For us it does not matter, it was requested by core.

Bumping the major

  • we need to handle the new Error codes as semver-major?
  • we will take our time if needed

Errors - #297

  • custom error types are very hard to do in browsers, we cannot do them (Calvin, Yosh, Irina)
  • codes we can do
  • We can replace new error.Error(code) with buildError(code) and we would need to ship our messages bundled.
  • We can then decide if it's semver-major or not (depends if we change the error messages).

Automatic string decoding for writable streams nodejs/node#7315

See our response in: nodejs/node#7315 (comment)

stream.end(chunk, enc, cb) should always call the callback nodejs/node#5540

See our response in: nodejs/node#5540 (comment)

@mcollina
Copy link
Member Author

@sonewman no worries! Thanks for joining!

@jalafel
Copy link

jalafel commented Sep 12, 2017

@mcollina Sorry I missed this! I got the date wrong, is there a recording I can listen to?

@mcollina
Copy link
Member Author

The youtube link above should work: http://youtu.be/pzHK1iJVGic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants