Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testsuite with recent tap #335

Closed
bastien-roucaries opened this issue Jun 1, 2018 · 1 comment
Closed

Fix testsuite with recent tap #335

bastien-roucaries opened this issue Jun 1, 2018 · 1 comment

Comments

@bastien-roucaries
Copy link

Hi,

Debian will carry this patch. Care to patch in your side

diff --git a/test/parallel/test-stream-end-paused.js b/test/parallel/test-stream-end-paused.js
index eeea575..6c64edd 100644
--- a/test/parallel/test-stream-end-paused.js
+++ b/test/parallel/test-stream-end-paused.js
@@ -25,6 +25,8 @@ var bufferShim = require('safe-buffer').Buffer;
 var common = require('../common');
 var assert = require('assert/');
 
+console.log('1..1')
+
 // Make sure we don't miss the end event for paused 0-length streams
 
 var Readable = require('../../').Readable;
diff --git a/test/parallel/test-stream-push-order.js b/test/parallel/test-stream-push-order.js
index 166d51d..ce06f28 100644
--- a/test/parallel/test-stream-push-order.js
+++ b/test/parallel/test-stream-push-order.js
@@ -33,6 +33,8 @@ var s = new Readable({
 
 var list = ['1', '2', '3', '4', '5', '6'];
 
+console.log('1..1')
+
 s._read = function (n) {
   var one = list.shift();
   if (!one) {
diff --git a/test/parallel/test-stream-push-strings.js b/test/parallel/test-stream-push-strings.js
index 00a6e83..6a41f13 100644
--- a/test/parallel/test-stream-push-strings.js
+++ b/test/parallel/test-stream-push-strings.js
@@ -33,6 +33,8 @@ var assert = require('assert/');
 
 var Readable = require('../../').Readable;
 
+console.log('1..1')
+
 var MyStream = function (_Readable) {
   _inherits(MyStream, _Readable);
 
diff --git a/test/parallel/test-stream-readable-flow-recursion.js b/test/parallel/test-stream-readable-flow-recursion.js
index 0b6704a..326e4f4 100644
--- a/test/parallel/test-stream-readable-flow-recursion.js
+++ b/test/parallel/test-stream-readable-flow-recursion.js
@@ -35,6 +35,8 @@ var Readable = require('../../').Readable;
 // throw an error if we trigger a nextTick warning.
 process.throwDeprecation = true;
 
+console.log('1..1')
+
 var stream = new Readable({ highWaterMark: 2 });
 var reads = 0;
 var total = 5000;
diff --git a/test/parallel/test-stream-unshift-empty-chunk.js b/test/parallel/test-stream-unshift-empty-chunk.js
index fcc5457..6f3d74d 100644
--- a/test/parallel/test-stream-unshift-empty-chunk.js
+++ b/test/parallel/test-stream-unshift-empty-chunk.js
@@ -25,6 +25,8 @@ var bufferShim = require('safe-buffer').Buffer;
 require('../common');
 var assert = require('assert/');
 
+console.log('1..1')
+
 // This test verifies that stream.unshift(bufferShim.alloc(0)) or
 // stream.unshift('') does not set state.reading=false.
 var Readable = require('../../').Readable;
diff --git a/test/parallel/test-stream-unshift-read-race.js b/test/parallel/test-stream-unshift-read-race.js
index 0e615db..5ff7f4a 100644
--- a/test/parallel/test-stream-unshift-read-race.js
+++ b/test/parallel/test-stream-unshift-read-race.js
@@ -37,6 +37,8 @@ var hwm = 10;
 var r = stream.Readable({ highWaterMark: hwm });
 var chunks = 10;
 
+console.log('1..1');
+
 var data = bufferShim.allocUnsafe(chunks * hwm + Math.ceil(hwm / 2));
 for (var i = 0; i < data.length; i++) {
   var c = 'asdf'.charCodeAt(i % 4);
diff --git a/test/parallel/test-stream-writev.js b/test/parallel/test-stream-writev.js
index 478121e..1cf00d9 100644
--- a/test/parallel/test-stream-writev.js
+++ b/test/parallel/test-stream-writev.js
@@ -27,6 +27,8 @@ var assert = require('assert/');
 
 var stream = require('../../');
 
+console.log('1..1')
+
 var queue = [];
 for (var decode = 0; decode < 2; decode++) {
   for (var uncork = 0; uncork < 2; uncork++) {
diff --git a/test/parallel/test-stream2-compatibility.js b/test/parallel/test-stream2-compatibility.js
index 4737f9a..3026de2 100644
--- a/test/parallel/test-stream2-compatibility.js
+++ b/test/parallel/test-stream2-compatibility.js
@@ -33,6 +33,8 @@ var R = require('../../lib/_stream_readable');
 var W = require('../../lib/_stream_writable');
 var assert = require('assert/');
 
+console.log('1..2');
+
 var ondataCalled = 0;
 
 var TestReader = function (_R) {
diff --git a/test/parallel/test-stream2-pipe-error-once-listener.js b/test/parallel/test-stream2-pipe-error-once-listener.js
index 2b8e467..40bb867 100644
--- a/test/parallel/test-stream2-pipe-error-once-listener.js
+++ b/test/parallel/test-stream2-pipe-error-once-listener.js
@@ -29,6 +29,8 @@ function _inherits(subClass, superClass) { if (typeof superClass !== "function"
 var bufferShim = require('safe-buffer').Buffer;
 /*</replacement>*/
 
+console.log('1..1');
+
 require('../common');
 var stream = require('../../');
 
diff --git a/test/parallel/test-stream2-push.js b/test/parallel/test-stream2-push.js
index 358e57a..17d871c 100644
--- a/test/parallel/test-stream2-push.js
+++ b/test/parallel/test-stream2-push.js
@@ -31,6 +31,8 @@ var _require = require('../../'),
 
 var EE = require('events').EventEmitter;
 
+console.log('1..1');
+
 // a mock thing a bit like the net.Socket/tcp_wrap.handle interaction
 
 var stream = new Readable({
diff --git a/test/parallel/test-stream2-readable-empty-buffer-no-eof.js b/test/parallel/test-stream2-readable-empty-buffer-no-eof.js
index 8371ac1..d936211 100644
--- a/test/parallel/test-stream2-readable-empty-buffer-no-eof.js
+++ b/test/parallel/test-stream2-readable-empty-buffer-no-eof.js
@@ -27,6 +27,8 @@ var assert = require('assert/');
 
 var Readable = require('../../').Readable;
 
+console.log('1..2');
+
 test1();
 test2();
 
diff --git a/test/parallel/test-stream2-unpipe-drain.js b/test/parallel/test-stream2-unpipe-drain.js
index 160ded4..2719ff3 100644
--- a/test/parallel/test-stream2-unpipe-drain.js
+++ b/test/parallel/test-stream2-unpipe-drain.js
@@ -44,7 +44,7 @@ function _inherits(subClass, superClass) { if (typeof superClass !== "function"
     }
 
     TestWriter.prototype._write = function _write(buffer, encoding, callback) {
-      console.log('write called');
+      //console.log('write called');
       // super slow write stream (callback never called)
     };
 
diff --git a/test/parallel/test-stream2-unpipe-leak.js b/test/parallel/test-stream2-unpipe-leak.js
index e77e939..1f3ae72 100644
--- a/test/parallel/test-stream2-unpipe-leak.js
+++ b/test/parallel/test-stream2-unpipe-leak.js
@@ -34,6 +34,8 @@ var stream = require('../../');
 
 var chunk = bufferShim.from('hallo');
 
+console.log('1..1');
+
 var TestWriter = function (_stream$Writable) {
   _inherits(TestWriter, _stream$Writable);
 
diff --git a/test/parallel/test-stream3-cork-uncork.js b/test/parallel/test-stream3-cork-uncork.js
index d80e764..ccac970 100644
--- a/test/parallel/test-stream3-cork-uncork.js
+++ b/test/parallel/test-stream3-cork-uncork.js
@@ -13,6 +13,8 @@ var Writable = stream.Writable;
 //
 // node version target: 0.12
 
+console.log('1')
+
 var expectedChunks = ['please', 'buffer', 'me', 'kindly'];
 var inputChunks = expectedChunks.slice(0);
 var seenChunks = [];
diff --git a/test/parallel/test-stream3-pause-then-read.js b/test/parallel/test-stream3-pause-then-read.js
index a026949..d49717f 100644
--- a/test/parallel/test-stream3-pause-then-read.js
+++ b/test/parallel/test-stream3-pause-then-read.js
@@ -49,6 +49,7 @@ function push() {
   r.push(chunk);
 }
 
+console.log('1..1');
 read100();
 
 // first we read 100 bytes
@mcollina
Copy link
Member

mcollina commented Jun 3, 2018

The way things are set up in this repo requires the change to be done in the build script instead, as the tests are pulled from node core.

This will be fixed in the next major release anyway.

mcollina added a commit that referenced this issue Aug 10, 2018
Fixes #283
Fixes #284
Fixes #212
Fixes #297
Fixes #346
Fixes #339
Fixed #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants