Node 8.1.3 #306
Merged
Node 8.1.3 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinmetcalf
approved these changes
Jun 29, 2017
yoshuawuyts
reviewed
Jun 29, 2017
| function _uint8ArrayToBuffer(chunk) { | ||
| return Buffer.from(chunk); | ||
| } | ||
| function _isUint8Array(obj) { | ||
| return Object.prototype.toString.call(obj) === '[object Uint8Array]' || Buffer.isBuffer(obj); | ||
| return Buffer.isBuffer(obj) || obj instanceof OurUint8Array; |
There was a problem hiding this comment.
Just to check: this is meant to always pass in environments that don't have global.Uint8Array, right?
There was a problem hiding this comment.
e.g. resolves to obj instanceOf Function
yoshuawuyts
reviewed
Jun 29, 2017
| @@ -660,4 +661,4 @@ Writable.prototype._undestroy = destroyImpl.undestroy; | |||
| Writable.prototype._destroy = function (err, cb) { | |||
| this.end(); | |||
| cb(err); | |||
| }; | |||
| }; | |||
yoshuawuyts
reviewed
Jun 29, 2017
| })); | ||
|
|
||
| _stream2.write(undefined); | ||
| } |
yoshuawuyts
approved these changes
Jun 29, 2017
|
The nits are out of babel, so there is not much we can do about them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #304 and #303.
Fixes #302
Fixes #305