src: handle object name errors more gracefully #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These appear to be from clients sending chunks of the directory listing html as the path in the url (e.g. `https://nodejs.org/dist/v21.2.0-aix-ppc64.tar.gz'%3Enode-v21.2.0-aix-ppc64.tar.gz%3C/a%3E%3C/` -> `https://nodejs.org/dist/v21.2.0-aix-ppc64.tar.gz'>node-v21.2.0-aix-ppc64.tar.gz</a></`) Closes #165 Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
ovflowd
reviewed
Nov 11, 2024
| return new Response(undefined, { status: 416 }); | ||
| if (err instanceof Error) { | ||
| if (err.message.includes('10020')) { | ||
| // Object name not valid, url probably has some weirdness in it |
There was a problem hiding this comment.
Can you link docs to these errors? Maybe ref to the source of Wrangler?
There was a problem hiding this comment.
There doesn't appear to be any docs regarding these, opened cloudflare/cloudflare-docs#18098
ovflowd
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These appear to be from clients sending chunks of the directory listing html as the path in the url (e.g.
https://nodejs.org/dist/v21.2.0-aix-ppc64.tar.gz'%3Enode-v21.2.0-aix-ppc64.tar.gz%3C/a%3E%3C/->https://nodejs.org/dist/v21.2.0-aix-ppc64.tar.gz'>node-v21.2.0-aix-ppc64.tar.gz</a></)Closes #165