Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate illformed YAML comments #180

Merged
merged 1 commit into from
Apr 24, 2021
Merged

feat: validate illformed YAML comments #180

merged 1 commit into from
Apr 24, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 21, 2021

@Trott
Copy link
Member

Trott commented Apr 24, 2021

I guess ideally we'd have tests for things like this, but uh...adding a unit testing system is out of scope.

@Trott Trott merged commit ac102a7 into nodejs:main Apr 24, 2021
@aduh95 aduh95 deleted the yaml-spacer branch April 24, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@nschonni nschonni nschonni approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @Trott @nschonni @richardlau