Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expand CI test globs #34

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

nschonni
Copy link
Member

Releated to #31
Doesn't include tools/doc or test

@nschonni
Copy link
Member Author

Will probably need nodejs/node#29963 to pass

@Trott
Copy link
Member

Trott commented Oct 15, 2019

nodejs/node#29963

Any Collaborators wanting to speed this along: Go approve fast-tracking at nodejs/node#29963 (comment)!

@nschonni nschonni force-pushed the chore--Expand-CI-test-globs branch 2 times, most recently from 764980f to 50b104a Compare October 15, 2019 04:52
Copy link
Contributor

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please quote the globs with double quotes; this fails in some shells

@XhmikosR
Copy link
Contributor

I wonder, can't we add a remark config file? It seems it'd be cleaner.

@nschonni
Copy link
Member Author

I believe I tried that already, but their ignore system doesn't work properly with the CLI and causes failures still

@XhmikosR
Copy link
Contributor

NP, I guess we'll live with it :) Just make sure you double quote the globs.

@nschonni
Copy link
Member Author

Should just need the cleanups in nodejs/node#29982 now

@Trott
Copy link
Member

Trott commented Oct 15, 2019

Should just need the cleanups in nodejs/node#29982 now

Those cleanups landed, so re-running checks now.

@nschonni
Copy link
Member Author

Thanks, looks like it's happy again

@Trott Trott merged commit 7e357aa into nodejs:master Oct 16, 2019
@nschonni nschonni deleted the chore--Expand-CI-test-globs branch October 16, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants