Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update maximum line length to 120 #500

Merged
merged 1 commit into from
Mar 10, 2024
Merged

fix: update maximum line length to 120 #500

merged 1 commit into from
Mar 10, 2024

Conversation

joyeecheung
Copy link
Member

To match eslint settings for JavaScript

To match eslint settings for JavaScript
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this require a massive PR on nodejs/node because format-md suddenly wants to change all the markdown files?

@joyeecheung
Copy link
Member Author

joyeecheung commented Feb 26, 2024

I don't ever recall when I write a line that could've been longer, format-md would attempt to make it longer than it already is. Locally modifying https://github.com/nodejs/node/blob/a8de25ed1523594dd6bf0ee08a24f146d38cb4e8/tools/lint-md/lint-md.mjs#L19519 and running make format-md doesn't change anything.

@joyeecheung
Copy link
Member Author

cc @nodejs/linting

@aduh95 aduh95 merged commit dca7621 into main Mar 10, 2024
4 checks passed
@aduh95 aduh95 deleted the max-len branch March 10, 2024 18:42
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
## [5.0.1](v5.0.0...v5.0.1) (2024-04-18)

### Bug Fixes

* update maximum line length to 120 ([#500](#500)) ([dca7621](dca7621))

### Trivial Changes

* add semantic-release automatic releases ([9dfa537](9dfa537))
* remove rule already included by recommended rules ([9e1d369](9e1d369))
* upgrade to ESLint 9 for dev tooling ([a213da9](a213da9))
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants