Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add third party vuln process #57

Merged
merged 1 commit into from
Dec 8, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 95 additions & 0 deletions processes/third_party_vuln_process.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
This document describes the management of vulnerabilities within the Node.js
ecosystem. Vulnerabilities in Node.js core are out of this scope.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying that, we will end up collecting vulnerabilities for Front-end packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps link here to https://nodejs.org/en/security/ or something like that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the nsp database includes a couple front-end packages, as does snyk's database. There are lots of FE code distributed via npmjs.org. Node "app" developers (or users of those apps when they are insecure) don't necessarily distinguish between a "vuln in js code evaluated by node" and "vuln in js code served by node to a FE, and evaluated by a web browser". We need to be really clear, though, on what the scope is if the DB managed by the Node Foundation. Is it packages in npmjs.org? Or, is it node javascript packages (no matter where accessed from)? Both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We historically considered anything within npm to be in scope for what to include in our ecosystem initiative.


# Definitions

* package: in this document, a package is a module available for use with Node.js
and hosted on the npmjs.org repository.

# Process

Individuals who find potential vulnerabilities in a package are invited
to complete a vulnerability report on the dedicated HackerOne organization:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should also be possible for a vulnerability to be reported via email (which can be forwarded to HackerOne and will auto-create a vuln report).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an issue on setting up this on H1 side right now. I have pinged H1 on that for assistance.

[https://hackerone.com/nodesecurity](https://hackerone.com/nodesecurity)

Vulnerabilities can also be reported by emailing security-ecosystem@nodejs.org.

When a potential vulnerability is reported, the following actions are taken:

## Triage

**Who:** The triage team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this list who the members of the triage team are? I assume this is made up of the current recipients of the security@ messages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is this specifically only for module vulnerabilities?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell This is a separate group for triage of non-core vulnerabilities.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once #56 lands, this PR can also include addition of a Team to the doc describing privacy policy, because the same privacy policy should apply to thirdparty vulns as to core (I think)


**Delay:** 48 hours

Within 48 hours, a member of the triage team provides a first answer to the
individual who submitted the potential vulnerability. The possible responses
can be:

* Acceptance: what was reported is considered as a new vulnerability
* Rejection: what was reported is not considered as a new vulnerability
* Need more information: the triage team needs more information in order to evaluate what was reported.

## Correction follow-up

**Who:** A member of the triage team

**Delay:** 45 days

When a vulnerability is confirmed, a member of the triage team is
designated to follow up on this report.

With the help of the individual who reported the vulnerability, they contact
the maintainers of the vulnerable package to make them aware of the
vulnerability.

With the package maintainer, they define a release date for the publication
of the vulnerability. Ideally, this release date should not happen before
the package has been patched.

If the maintainers are unreachable, the vulnerability is to be made public
45 days after the triage date.


## Publication

**Who:** A member of the triage team

**Delay:** 45 days

Within 45 days after the triage date, the vulnerability must be made public.

If a patch is being actively developed by the package maintainer, an additional delay
can be added with the approval of the triage team and the individual who
reported the vulnerability (this is a simple vote where each member of the
triage team and the vulnerability reporter have 1 vote each).

The vulnerability is considered as published when a Pull Request adding it
to this repository is opened.

Within HackerOne, this is handled through a "public disclosure request".

## Vulnerabilities found outside this process

Vulnerabilities found and fixed outside this process should be added into
the vulnerability database. This can be done by anyone through a Pull Request on
this repository.

# The triage team

The triage team is composed of 5 or more members of the security working group.
This team is approved and modified by a vote from the working group.

They are responsible for the management of this process.

Each member of the triage team is expected to handle vulnerabilities on a
regular basis.

Members of this team are required to follow the same NDA and privacy measures
as the [Node.js Security Team](https://github.com/nodejs/security-wg/blob/master/processes/security_team_members.md).

Members of the security teams should indicate that they accept the privacy policies
by PRing their acceptance to this file:

* @vdeturckheim - Vladimir de Turckheim