-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CII-Best-Practices for Nodejs: Silver level #955
CII-Best-Practices for Nodejs: Silver level #955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nodejs/security I closed the previous discussions and I added new ones.
The new ones are the last step before we can merge it 🙌
… feat/best-practices-silver
Ok, so we managed to close all the discussions! 🎉🎉 @nodejs/security: can you perform a final review and approve this version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the remaining threads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @nodejs/tsc
Thanks a lot for all the hard work! ❤️ As agreed in our last meeting, I will merge this PR. I hope to see the Silver badge soon 🙌 |
The project repository front page and/or website MUST identify and hyperlink to any achievements, including this best practices badge, within 48 hours of public recognition that the achievement has been attained. (URL required) | ||
|
||
**Met** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be missing the required URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch @tniessen. We have an issue open for it: nodejs/nodejs.org#5432 (comment). I hope that we can integrate it in the website 🤞
* feat: copied passing criterial Questions and Answers * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses * feat: update responses * feat: update responses * Update tools/ossf_best_practices/silver_criteria.md * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) --------- Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
* feat: copied passing criterial Questions and Answers * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses * feat: update responses * feat: update responses * Update tools/ossf_best_practices/silver_criteria.md * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) --------- Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
Related #953
This pull request contains a dump of the current questions and answers for the Node.js project in OpenSSF Best Practices for Silver Level. The purpose is to review the current answers, update and comment on them until we have a final version, and then update the OpenSSF Best Practices site.