Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Node 8.1.2 #3

Closed
wants to merge 1 commit into from
Closed

Updated to Node 8.1.2 #3

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

@addaleax Can you have a look while this fails in Node < 8?

cc @calvinmetcalf

@calvinmetcalf
Copy link
Contributor

it's actually the current one too that fails in node 8

@mcollina
Copy link
Member Author

the current one fails on node >= 8, while this one fails on Node < 8

@calvinmetcalf
Copy link
Contributor

ah, confusing breaking change of some sort

@mcollina
Copy link
Member Author

So, I think it might be related to something low level, and we need to abstract the test.

@mcollina
Copy link
Member Author

I think this the source of the problem: nodejs/node@24ef1e6

I think we should just conditionally pick the right test depending on the version of V8 we running against.

@mcollina
Copy link
Member Author

I have disabled the V8-dependant checks.

@mcollina
Copy link
Member Author

Closed in favor of #6

@mcollina mcollina closed this Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants