fix: throw on keep-alive header (#273)

nodejs · Jul 30, 2020 · be9fc08 · be9fc08
1 parent fea2fd6
commit be9fc08
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/lib/client.js b/lib/client.js
@@ -419,6 +419,7 @@ class Parser extends HTTPParser {
     const request = client[kQueue][client[kRunningIdx]]
 
     // TODO: Check for content-length mismatch?
+    // TODO: keep-alive timeout & max?
 
     assert(this.statusCode < 200)
 
@@ -815,6 +816,8 @@ function write (client, request) {
     socket.write(`content-length: ${contentLength}\r\n`, 'ascii')
   }
 
+  // TODO: keep-alive timeout=client[kSocketTimeout]?
+
   if (method === 'HEAD') {
     // https://github.com/mcollina/undici/issues/258
 

diff --git a/lib/request.js b/lib/request.js
@@ -122,6 +122,11 @@ class Request extends AsyncResource {
             key.toLowerCase() === 'connection'
           ) {
             throw new InvalidArgumentError('invalid connection header')
+          } else if (
+            key.length === 10 &&
+            key.toLowerCase() === 'keep-alive'
+          ) {
+            throw new InvalidArgumentError('invalid keep-alive header')
           } else {
             header += `${key}: ${val}\r\n`
           }

diff --git a/test/invalid-headers.js b/test/invalid-headers.js
@@ -4,7 +4,7 @@ const { test } = require('tap')
 const { Client, errors } = require('..')
 
 test('invalid headers', (t) => {
-  t.plan(5)
+  t.plan(6)
 
   const client = new Client('http://localhost:3000')
   t.teardown(client.destroy.bind(client))
@@ -38,6 +38,16 @@ test('invalid headers', (t) => {
     t.ok(err instanceof errors.InvalidArgumentError)
   })
 
+  client.request({
+    path: '/',
+    method: 'GET',
+    headers: {
+      'keep-alive': 'timeout=5'
+    }
+  }, (err, data) => {
+    t.ok(err instanceof errors.InvalidArgumentError)
+  })
+
   client.request({
     path: '/',
     method: 'GET',