Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests don't seem to be running in the ci #1890

Closed
KhafraDev opened this issue Jan 27, 2023 · 1 comment
Closed

tests don't seem to be running in the ci #1890

KhafraDev opened this issue Jan 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@KhafraDev
Copy link
Member

KhafraDev commented Jan 27, 2023 •
edited
Loading

#1889
47f574d

None of the tests seem to be running:


The workflow is not valid. .github/workflows/nodejs.yml (Line: 13, Col: 5): Unexpected value 'uses' .github/workflows/nodejs.yml (Line: 14, Col: 5): Unexpected value 'with'
@KhafraDev KhafraDev added the bug Something isn't working label Jan 27, 2023
@mcollina
Copy link
Member

I configured timeout-minutes but it's incompatible with the action we use: pkgjs/action#53

mcollina added a commit that referenced this issue Jan 27, 2023
@mcollina
remove timeout-minutes in github action
196c4da 
Signed-off-by: Matteo Collina <hello@matteocollina.com>

fix #1890
anonrig pushed a commit to anonrig/undici that referenced this issue Apr 4, 2023
@mcollina @anonrig
remove timeout-minutes in github action
6a33626 
Signed-off-by: Matteo Collina <hello@matteocollina.com>

fix nodejs#1890
metcoder95 pushed a commit to metcoder95/undici that referenced this issue Jul 21, 2023
@mcollina @metcoder95
remove timeout-minutes in github action
c717fdd 
Signed-off-by: Matteo Collina <hello@matteocollina.com>

fix nodejs#1890
crysmags pushed a commit to crysmags/undici that referenced this issue Feb 27, 2024
@mcollina @crysmags
remove timeout-minutes in github action
012fddb 
Signed-off-by: Matteo Collina <hello@matteocollina.com>

fix nodejs#1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @KhafraDev