-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce default idle timeout? #276
Comments
Might not be a huge perf impact after #275. Assuming servers implement it. |
|
Wow, that's a large difference in policy... though I think we might have to aim for worst case? Or should we have some kind of lookup list for known CDNs? |
Would be nice to have some kind of test urls to see whether or not they set the |
That's definitely not enough. IMO it should default to 60s at least... I mean it depends on how often you query the server. It's hard to say. |
You can always override it... I think that by default we should be as compatible as possible. Within reason. Seems like cloudfront is a bit of an edge case at the moment. Would be very interesting to see whether they provide keep-alive hints or not... haven't been able to find any test url. |
Sad.
|
@szmarczak Actually, I think node also has 5s as default keepAliveTimeout... https://github.com/nodejs/node/blob/master/lib/_http_server.js#L369 |
Node HTTP server seem to have a default of 5 seconds and we should be below that. Fixes: #276
https://aws.amazon.com/about-aws/whats-new/2017/03/announcing-configure-read-timeout-and-keep-alive-timeout-values-for-your-amazon-cloudfront-custom-origins/
Cloudfront seems to default to 5 seconds. Might be safer for us to default to something like 2-3 seconds?
@mcollina @szmarczak Thoughts?
The text was updated successfully, but these errors were encountered: