Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in sample code #1178

Merged
merged 1 commit into from
Jan 26, 2022
Merged

docs: fix typo in sample code #1178

merged 1 commit into from
Jan 26, 2022

Conversation

snyamathi
Copy link
Contributor

@snyamathi snyamathi commented Jan 26, 2022

Minor issue I've found while making sense of the docs.

Uncaught TypeError: res is not async iterable

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #1178 (bd974d4) into main (5d52423) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   93.73%   93.70%   -0.03%     
==========================================
  Files          41       41              
  Lines        4020     4020              
==========================================
- Hits         3768     3767       -1     
- Misses        252      253       +1     
Impacted Files Coverage Δ
lib/fetch/request.js 81.74% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d52423...bd974d4. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2d03e77 into nodejs:main Jan 26, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants