Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mock utils): set Readable.abort #1549

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Jul 14, 2022

Fixes #1546

.abort is set once Dispatcher.onConnect is called, but it's possible the method doesn't exist (another test was failing with this change) and the semantics of calling it when no request was dispatched didn't make much sense to me.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #1549 (62c05a1) into main (22e2f39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1549   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          50       50           
  Lines        4677     4678    +1     
=======================================
+ Hits         4440     4441    +1     
  Misses        237      237           
Impacted Files Coverage Δ
lib/mock/mock-utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e2f39...62c05a1. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6c9e634 into nodejs:main Jul 14, 2022
@KhafraDev KhafraDev deleted the mock-body-errors branch July 18, 2022 20:09
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When mocking a response with MockAgent errors are different from a real request
4 participants