Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch
can makeworker_threads
stuck and process hang #2026Example of failure on CI: https://github.com/AriPerkkio/undici/actions/runs/4551514748/jobs/8025677893#step:14:12832
Somehow
tap
is able to kill the process even though workers cannot terminate. I'm not sure how it does that as the reproduction case of #2026 cannot exit main thread even when it callsprocess.exit()
.Replace
fetch
withrequest
and test case will pass.