Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use class instead of object literals with getters #3138

Merged
merged 12 commits into from
Apr 21, 2024
Merged

perf: use class instead of object literals with getters #3138

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6833268
perf: use class instead of object literals with getters
tsctx Apr 19, 2024
c2e5ca9
may not be needed
tsctx Apr 19, 2024
de2ed97
update
tsctx Apr 20, 2024
356ff78
remove realm from headers and signal
tsctx Apr 20, 2024
b508cf8
use class in Response
tsctx Apr 20, 2024
919b092
fix lint
tsctx Apr 20, 2024
6285929
Update lib/web/fetch/request.js
tsctx Apr 20, 2024
1192162
use shared realm
tsctx Apr 21, 2024
e3b095b
fix lint
tsctx Apr 21, 2024
cbc3d40
use Environment Settings Object baseUrl
tsctx Apr 21, 2024
f85de4d
Update lib/web/fetch/util.js
tsctx Apr 21, 2024
29ee9ac
Update lib/web/fetch/util.js
tsctx Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions benchmarks/fetch/request-creation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { bench, run } from 'mitata'
import { Request } from '../../lib/web/fetch/request.js'

const input = 'https://example.com/post'

bench('new Request(input)', () => new Request(input, undefined))

await run()
20 changes: 13 additions & 7 deletions lib/web/fetch/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ const requestFinalizer = new FinalizationRegistry(({ signal, abort }) => {

let patchMethodWarning = false

class RequestRealmSettingsObject {
baseUrl = getGlobalOrigin()

get origin () {
return this.baseUrl?.origin
}

policyContainer = makePolicyContainer()
}

// https://fetch.spec.whatwg.org/#request-class
class Request {
// https://fetch.spec.whatwg.org/#dom-request
Expand All @@ -56,13 +66,9 @@ class Request {

// https://html.spec.whatwg.org/multipage/webappapis.html#environment-settings-object
this[kRealm] = {
settingsObject: {
baseUrl: getGlobalOrigin(),
get origin () {
return this.baseUrl?.origin
},
policyContainer: makePolicyContainer()
}
// Note: Slow initialization of object literals with getters.
// TODO: Remove workaround.
settingsObject: new RequestRealmSettingsObject()
}

// 1. Let request be null.
Expand Down
Loading