Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file #3367

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Remove file #3367

merged 2 commits into from
Jul 3, 2024

Conversation

KhafraDev
Copy link
Member

depends on #3366

File has been a wrapper for node's global File for a little bit, no reason to keep it.

@ronag
Copy link
Member

ronag commented Jun 25, 2024

We can't merge this into main due to semver-majorness...

@ronag ronag added the semver-major Features or fixes that will be included in the next semver major release label Jun 25, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 0adc3d4 into nodejs:main Jul 3, 2024
30 checks passed
@KhafraDev KhafraDev deleted the remove-file branch September 3, 2024 16:53
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major Features or fixes that will be included in the next semver major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants