Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement BodyReadable.bytes #3391

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Jul 3, 2024

Refs: #3262

@tsctx tsctx force-pushed the implement-readable-bytes branch from 952d8ef to 4712ae8 Compare July 3, 2024 11:21
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the docs?

Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a side note we should probably add a test similar to 9134ee6 to be safe

@tsctx
Copy link
Member Author

tsctx commented Jul 4, 2024

@mcollina ptal

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit db8e642 into nodejs:main Jul 6, 2024
30 checks passed
@tsctx tsctx deleted the implement-readable-bytes branch July 6, 2024 20:44
github-actions bot pushed a commit that referenced this pull request Oct 10, 2024
tsctx added a commit that referenced this pull request Oct 10, 2024
(cherry picked from commit db8e642)

Co-authored-by: tsctx <91457664+tsctx@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants