Fix signature of RetryHandler #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the typings of [RetryCallback](https://github.com/nodejs/undici/blob/main/types/retry-handler.d.ts#L26), I saw that it must return `number | null` but the [documentation](https://undici.nodejs.org/#/docs/api/RetryAgent?id=parameter-retryhandleroptions) says `void`.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
(cherry picked from commit 5335013)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Looking at the typings of RetryHandler, I saw that it must return
number | nullbut the documentation saysvoid.Changes
Fixed the documentation page for RetryHandler
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
None
Status