Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instantiation of SecureProxyConnectionError should pass options to parent class #3473

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 16, 2024

calling super(message, options) was not working.

Is there a reason, that we set cause "manually"?

@Uzlopak Uzlopak requested a review from mcollina August 16, 2024 16:48
@Uzlopak Uzlopak merged commit c1654af into nodejs:main Aug 19, 2024
32 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants