Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change webidl.util.Type return to an enum value #3520

Merged
merged 1 commit into from
Aug 28, 2024
Merged

change webidl.util.Type return to an enum value #3520

merged 1 commit into from
Aug 28, 2024

Conversation

KhafraDev
Copy link
Member

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 28, 2024

can you explain a little?

also why is function an object?

@KhafraDev
Copy link
Member Author

  1. string comparisons are slow, in webidl we want to squeeze out any amount of performance we can get

  2. https://tc39.es/ecma262/#sec-object-type

In addition, some objects are callable; these are referred to as functions or function objects and are described further below. All functions in ECMAScript are members of the Object type.

@Uzlopak Uzlopak merged commit 7c1066c into nodejs:main Aug 28, 2024
32 of 33 checks passed
@KhafraDev KhafraDev deleted the webidl-type-enum branch August 29, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@tsctx tsctx tsctx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhafraDev @Uzlopak @tsctx