Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle body errors #3632

Merged
merged 1 commit into from
Sep 20, 2024
Merged

handle body errors #3632

merged 1 commit into from
Sep 20, 2024

Conversation

KhafraDev
Copy link
Member

fixes #3616

Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
@KhafraDev KhafraDev merged commit 862c035 into nodejs:main Sep 20, 2024
32 checks passed
@KhafraDev KhafraDev deleted the body-error branch September 20, 2024 16:24
@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 20, 2024

Very good code ;)

Copy link
Contributor

github-actions bot commented Oct 8, 2024

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3632-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 862c0354ce8a9d9972029a7154255eaabed0bb51
# Push it to GitHub
git push --set-upstream origin backport-3632-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3632-to-v6.x.

Uzlopak pushed a commit that referenced this pull request Oct 8, 2024
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
(cherry picked from commit 862c035)
Uzlopak added a commit that referenced this pull request Oct 8, 2024
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
(cherry picked from commit 862c035)

Co-authored-by: Khafra <maitken033380023@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants