Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(H2): onboard H2 into Undici queueing system #3707

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Oct 9, 2024

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@metcoder95 metcoder95 linked an issue Oct 9, 2024 that may be closed by this pull request
@metcoder95 metcoder95 requested review from mcollina and ronag October 10, 2024 06:27
test/http2.js Outdated Show resolved Hide resolved
test/http2.js Outdated Show resolved Hide resolved
test/http2.js Outdated Show resolved Hide resolved
test/http2.js Outdated Show resolved Hide resolved
test/http2.js Outdated Show resolved Hide resolved
test/http2.js Outdated Show resolved Hide resolved
test/http2.js Outdated Show resolved Hide resolved
@metcoder95
Copy link
Member Author

Are we good to merge @mcollina?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/http2.js Outdated
await t.completed
})

test('#3671 - Graceful close', { only: true }, async (t) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove only

@mcollina mcollina merged commit d6c44f3 into main Oct 12, 2024
38 checks passed
@Uzlopak Uzlopak deleted the chore/h2_queue branch October 12, 2024 06:31
Copy link
Contributor

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3707-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d6c44f3b49949dbdd66d9c56e729d503e6b09ddc
# Push it to GitHub
git push --set-upstream origin backport-3707-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3707-to-v6.x.

Uzlopak pushed a commit that referenced this pull request Oct 12, 2024
Uzlopak added a commit that referenced this pull request Oct 12, 2024
(cherry picked from commit d6c44f3)

Co-authored-by: Carlos Fuentes <me@metcoder.dev>
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client.close() does not wait for requests to finish in HTTP2 mode
4 participants