fix: handle case no content type #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase/update this branch? |
metcoder95
reviewed
Dec 8, 2024
Gigioliva
force-pushed
the
fix/type-not-defined
branch
from
9f80c0d to
1e935a0
Compare
Done... but still there are some flaky tests |
|
This now conflicts, could you update? Unfortunately that's a known flake. |
1 similar comment
|
This now conflicts, could you update? Unfortunately that's a known flake. |
Gigioliva
force-pushed
the
fix/type-not-defined
branch
from
1e935a0 to
df7635e
Compare
metcoder95
approved these changes
Dec 8, 2024
|
All good? or something is missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case server doesn't include
content-typeRationale
If the server does not return the value for
content-type, the interceptor raises an exception since it tries to useindexOfof undefined.Changes
Add a fallback in case
#contentTypeis undefined.Bug Fixes
Fix this issue
Status