Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#3937): respect correct host header #3940

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(#3937): respect correct host header #3940

merged 2 commits into from
Dec 10, 2024

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Dec 10, 2024 •
edited
Loading

This relates to...

Closes #3937

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@metcoder95 metcoder95 requested a review from ronag December 10, 2024 07:59
mcollina
mcollina approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a nit

test/interceptors/dns.js Outdated Show resolved Hide resolved
@metcoder95 @mcollina
Update test/interceptors/dns.js
dbc692d 
Co-authored-by: Matteo Collina <hello@matteocollina.com>
@ronag ronag merged commit 81416fc into main Dec 10, 2024
37 checks passed
@metcoder95 metcoder95 deleted the fix/3937 branch December 10, 2024 19:26
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dns interceptor doesn't set port in host header
3 participants
@metcoder95 @mcollina @ronag