Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3951): typo on errorede dns lookup #3956

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix(3951): typo on errorede dns lookup #3956

merged 2 commits into from
Dec 18, 2024

Conversation

metcoder95
Copy link
Member

This relates to...

Closes #3951

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

luddd3 added a commit to luddd3/undici that referenced this pull request Dec 17, 2024
Depends on PR nodejs#3956 being merged first.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

metcoder95 pushed a commit that referenced this pull request Dec 18, 2024
* fix: undefined function called

* test: easier test

Depends on PR #3956 being merged first.
@metcoder95 metcoder95 requested a review from mcollina December 18, 2024 10:17
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3eeeeb7 into main Dec 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EAI_AGAIN Error Not Thrown on getaddrinfo Failure
3 participants