Skip to content
This repository has been archived by the owner on Jan 10, 2020. It is now read-only.

initial draft of tooling initiatives doc #70

Merged
merged 1 commit into from
Jul 9, 2018
Merged

initial draft of tooling initiatives doc #70

merged 1 commit into from
Jul 9, 2018

Conversation

boneskull
Copy link
Contributor

Not sure where to put this doc exactly, but here it is.

References: #59, #68

@boneskull
Copy link
Contributor Author

cc's

@mhdawson @dshaw @bnb @cb1kenobi @devsnek @iarna @TheLarkInn @hansl @stefanpenner @zertosh

stefanpenner
stefanpenner reviewed Jun 8, 2018
View reviewed changes
groups/tooling/README.md

### Summary

Two (2) filesystem operations should be added to Node.js Core:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big +1, its not uncommon to have 15-25+ mkdirp modules in node_modules, and about the same for fs-extra

@styfle styfle mentioned this pull request Jun 8, 2018
Open
mhdawson
mhdawson approved these changes Jun 11, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this can go in as is and then be refined. When there are future initiatives, it may make sense to have the description for each one in its own file (ex common-file-ops.md) and then have the README provide the top level list.

@boneskull
Copy link
Contributor Author

Would anyone like to merge?

@mhdawson mhdawson merged commit b371e0a into nodejs:master Jul 9, 2018
@mhdawson
Copy link
Member

mhdawson commented Jul 9, 2018

Landed as b371e0a

@bcoe
Copy link

bcoe commented Jul 10, 2018

@mhdawson @boneskull @stefanpenner 🎉I'm excited about this. Having been working on Node command line tools in my spare time for years at this point (yargs, nyc, Istanbul), I'm used to my first action often being to npm i mkdirp and npm i rimraf.

I also have some grander thoughts around tooling as it relates to testing. Specifically, it would be nice to have source-map support (CC: @addaleax) which would simply most transpilation approaches, and make for better stack traces. Eventually I'd also love for us to find a lighter-weight way to expose v8 test coverage. (CC: @schuay). tldr; test coverage is built into v8, we shouldn't need to use transpilation to collect it in Node.js.

@boneskull and I have done a tiny bit of hacking so far on mkdirp, it seems like some great low hanging fruit. Let's get that common-file-ops.md started, which we can reference as we begin to evangelize tooling improvements.

@cb1kenobi
Copy link

+1 for source-map support as I previous suggested: #59 (comment).

bcoe pushed a commit to bcoe/node-1 that referenced this pull request Aug 10, 2018
fs: implement mkdir recursive (mkdirp) functionality
2ba6f29 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70
bcoe pushed a commit to nodejs/node that referenced this pull request Aug 11, 2018
fs: implement mkdir recursive (mkdirp)
bdef1b1 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70

PR-URL: #21875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
bcoe pushed a commit to nodejs/node that referenced this pull request Aug 11, 2018
fs: implement mkdir recursive (mkdirp)
fdeace6 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70

PR-URL: #21875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
rvagg pushed a commit to nodejs/node that referenced this pull request Aug 16, 2018
@rvagg
fs: implement mkdir recursive (mkdirp)
b1adb44 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70

PR-URL: #21875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax pushed a commit to nodejs/node that referenced this pull request Sep 3, 2018
@addaleax
fs: implement mkdir recursive (mkdirp)
2b20b67 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70

PR-URL: #21875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Sep 12, 2018
@targos
fs: implement mkdir recursive (mkdirp)
779e072 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70

PR-URL: #21875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Sep 19, 2018
@targos
fs: implement mkdir recursive (mkdirp)
0718780 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70

PR-URL: #21875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Sep 25, 2018
@targos
fs: implement mkdir recursive (mkdirp)
7e45daf 
Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: nodejs/user-feedback#70

PR-URL: #21875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanpenner stefanpenner stefanpenner left review comments

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boneskull @mhdawson @bcoe @cb1kenobi @stefanpenner