Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] use ljharb/actions/node/matrix #3

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Nov 27, 2024

(into #1)

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! BTW that cool action

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t! Thanks for this 🙏

@JakobJingleheimer JakobJingleheimer merged commit eef8d21 into nodejs:chore/initial-setup Nov 28, 2024
JakobJingleheimer added a commit that referenced this pull request Nov 28, 2024
@JakobJingleheimer
Copy link
Member

@ljharb something in here causes CI to fail on globs (ex https://github.com/nodejs/userland-migrations/actions/runs/12068897635/job/33654997438)

@ljharb ljharb deleted the matrix branch November 28, 2024 22:10
@ljharb
Copy link
Member Author

ljharb commented Nov 28, 2024

@JakobJingleheimer rather than reverting, it might be more helpful to print out node --version in the tests, to make sure it's using the right one? node itself is failing on the options, not the globs, from what i can see.

@richardlau
Copy link
Member

https://github.com/nodejs/userland-migrations/actions/runs/12068897635/job/33654997438#step:3:9 says it installed Node.js 20.18.1

@JakobJingleheimer
Copy link
Member

@JakobJingleheimer rather than reverting, it might be more helpful to print out node --version in the tests, to make sure it's using the right one? node itself is failing on the options, not the globs, from what i can see.

Ah, yes. I reverted because I think this is super cool but non-blocking. Since the parent PR is otherwise ready to go, I think we can figure this out and then as a subsequent enhancement. And the other landed, I think this will be easier to test 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants