-
Notifications
You must be signed in to change notification settings - Fork 52
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disallow malformed path with null byte (#266)
This commit adds a check when resolving path such that any null bytes in the input path causes errno `inval`. This is consistent with other runtimes like Wasmtime, Wasmer, Wazero, WasmEdge, and WAMR. fixes #265 Signed-off-by: Yage Hu <me@huyage.dev>
- Loading branch information
Showing
3 changed files
with
60 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
#include <assert.h> | ||
#include <stdint.h> | ||
#include <stdlib.h> | ||
#include <string.h> | ||
#include "uvwasi.h" | ||
#include "uv.h" | ||
#include "test-common.h" | ||
|
||
#define TEST_TMP_DIR "./out/tmp" | ||
|
||
int main(void) { | ||
const char* path = "file.txt\0"; | ||
uvwasi_t uvwasi; | ||
uvwasi_fd_t fd; | ||
uvwasi_options_t init_options; | ||
uvwasi_errno_t err; | ||
uv_fs_t req; | ||
int r; | ||
|
||
setup_test_environment(); | ||
|
||
r = uv_fs_mkdir(NULL, &req, TEST_TMP_DIR, 0777, NULL); | ||
uv_fs_req_cleanup(&req); | ||
assert(r == 0 || r == UV_EEXIST); | ||
|
||
uvwasi_options_init(&init_options); | ||
init_options.preopenc = 1; | ||
init_options.preopens = calloc(1, sizeof(uvwasi_preopen_t)); | ||
init_options.preopens[0].mapped_path = "/var"; | ||
init_options.preopens[0].real_path = TEST_TMP_DIR; | ||
|
||
err = uvwasi_init(&uvwasi, &init_options); | ||
assert(err == 0); | ||
|
||
// Create a file. | ||
err = uvwasi_path_open(&uvwasi, | ||
3, | ||
1, | ||
path, | ||
10, | ||
UVWASI_O_CREAT, | ||
0, | ||
0, | ||
0, | ||
&fd); | ||
assert(err == UVWASI_EINVAL); | ||
|
||
uvwasi_destroy(&uvwasi); | ||
free(init_options.preopens); | ||
|
||
return 0; | ||
} | ||
|