Should not be able to create a symlink to absolute path #271

yagehu · 2024-06-12T17:44:30Z

WASI specifies that such an operation should fail. Node with uvwasi currently successfully creates the symlink. Other runtimes (Wasmtime, Wasmer, WasmEdge, Wazero, WAMR) successfully block this call.

fn main() {
    unsafe {
        let base_fd = 3;

        wasi::path_symlink("/a", base_fd, "a").unwrap();
    }
}

This commit adds an absolute path check to `path_symlink`. This behavior is specified by [WASI][1]. [1]: https://github.com/WebAssembly/wasi-filesystem/blob/main/path-resolution.md#symlinks fixes nodejs#271 Signed-off-by: Yage Hu <me@huyage.dev>

This commit adds an absolute path check to `path_symlink`. This behavior is specified by [WASI][1]. [1]: https://github.com/WebAssembly/wasi-filesystem/blob/main/path-resolution.md#symlinks fixes #271 Signed-off-by: Yage Hu <me@huyage.dev>

yagehu mentioned this issue Jun 12, 2024

Error if creating symlink to absolute path #272

Merged

mhdawson closed this as completed in #272 Jul 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Should not be able to create a symlink to absolute path #271

Should not be able to create a symlink to absolute path #271

yagehu commented Jun 12, 2024 •

edited

Loading

Should not be able to create a symlink to absolute path #271

Should not be able to create a symlink to absolute path #271

Comments

yagehu commented Jun 12, 2024 • edited Loading

yagehu commented Jun 12, 2024 •

edited

Loading