Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const char* in uvwasi_preopen_s #130

Merged
merged 1 commit into from
May 17, 2020
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 17, 2020

This allows C strings to be assigned.

This allows C strings to be assigned.
Copy link
Collaborator

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cjihrig cjihrig merged commit ef04e8e into nodejs:master May 17, 2020
cjihrig added a commit that referenced this pull request Aug 2, 2020
Notable changes:

- The uvwasi_preopen_t now uses const char* for the mapped_path
  and real_path fields. Previously, these were not const.
  (#130)
- uvwasi_path_filestat_get() now properly handles the
  UVWASI_LOOKUP_SYMLINK_FOLLOW flag.
  (#133)
- uvwasi_options_init() has been added to reduce the boilerplate
  code associated with initializing uvwasi_options_t's.
  (#141)
- The DEBUG() macro has been renamed to UVWASI_DEBUG() to
  reduce naming conflicts with other projects.
  (#143)
- A compilation error on NetBSD 8.2 has been fixed.
  (#146)
- The uvwasi_fd_filestat_set_times() and
  uvwasi_path_filestat_set_times() functions now have proper
  implementations.
  (#139)
@cjihrig cjihrig mentioned this pull request Aug 2, 2020
cjihrig added a commit that referenced this pull request Aug 4, 2020
Notable changes:

- The uvwasi_preopen_t now uses const char* for the mapped_path
  and real_path fields. Previously, these were not const.
  (#130)
- uvwasi_path_filestat_get() now properly handles the
  UVWASI_LOOKUP_SYMLINK_FOLLOW flag.
  (#133)
- uvwasi_options_init() has been added to reduce the boilerplate
  code associated with initializing uvwasi_options_t's.
  (#141)
- The DEBUG() macro has been renamed to UVWASI_DEBUG() to
  reduce naming conflicts with other projects.
  (#143)
- A compilation error on NetBSD 8.2 has been fixed.
  (#146)
- The uvwasi_fd_filestat_set_times() and
  uvwasi_path_filestat_set_times() functions now have proper
  implementations.
  (#139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants