No-op instead of error on empty read/write #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit inserts a special case to `fd_{read,write,pread,pwrite}`
such that passing in an empty list of buffers results in a no-op. This
behavior is consistent with Linux host as well as other Wasm runtimes.
fixes nodejs#260
guybedford
approved these changes
Apr 19, 2024
yagehu
changed the title
Since some allocators return NULL if the size is 0, check the length before preparing buffers so that we don't erroneously return ENOMEM.
yagehu
changed the title
|
Some allocators return NULL if the size is 0, causing @guybedford @mhdawson Thanks for the review. The PR is ready again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit inserts a special case to
fd_{read,write,pread,pwrite}such that passing in an empty list of buffers results in a no-op. This behavior is consistent with Linux host as well as other Wasm runtimes.fixes #260