Preserve trailing slash in file path where it makes sense #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagehu
changed the title
yagehu
force-pushed
the
trailing-slash
branch
5 times, most recently
from
408d98b to
24348b8
Compare
yagehu
changed the title
yagehu
force-pushed
the
trailing-slash
branch
2 times, most recently
from
6bac726 to
9d5c862
Compare
This commit fixes the behavior of `path_open` such that if the path contains trailing slashes and the target file is not a directory, the call errors. This behavior is consistent with Linux host, Wasmtime, WAMR, and WasmEdge. fixes nodejs#267 Signed-off-by: Yage Hu <me@huyage.dev>
yagehu
changed the title
guybedford
approved these changes
Jun 10, 2024
|
It would be good to align with implementations on these errors, and given the current architecture handling it in the path normalization seems a good way to go about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the behavior of
path_opensuch that if the path contains trailing slashes and the target file is not a directory, the call errors. This behavior is consistent with Linux host, Wasmtime, WAMR, and WasmEdge.fixes #267