Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cflite and document normalize path #280

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

DavidKorczynski
Copy link
Contributor

Resolving: #251 (comment)

I also added a ClusterFuzzLite integration with the harness described in the issue.

The harness will be run when PRs are made against uvwasi.

To run the harness manually locally:

git clone https://github.com/google/oss-fuzz
git clone https://github.com/DavidKorczynski/uvwasi
cd uvwasi
git checkout enable-cflite

# Build the fuzzers in .clusterfuzzlite
python3 ../oss-fuzz/infra/helper.py build_fuzzers --external $PWD

# Run the fuzzer for 10 seconds
python3 ../oss-fuzz/infra/helper.py run_fuzzer --external $PWD fuzz_normalize_path -- -max_total_time=10

Fixes: #251

Fixes: nodejs#251

Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
@mhdawson
Copy link
Member

mhdawson commented Sep 5, 2024

@DavidKorczynski thanks, one more ask would be to add the instructions on how to run the fuzzers to the main readme. I think a section at the bottom titled 'Running the fuzzers locally' or something like that containing what you have in the description above would make it easier to find/run.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM with a suggestion

@DavidKorczynski
Copy link
Contributor Author

Overall LGTM with a suggestion

done

Signed-off-by: David Korczynski <david@adalogics.com>
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 6eeddba into nodejs:main Sep 16, 2024
8 checks passed
@mhdawson
Copy link
Member

@DavidKorczynski thanks for the doc/contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write-based buffer overflow in uvwasi__normalize_path
2 participants