New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

espconn lwip wrappers actively harmful #3004

Open

nwf opened this issue Jan 5, 2020 · 4 comments

Member

nwf commented Jan 5, 2020 •

edited

Loading

As far as I can tell, anyway, these things are just obstruction, rather than abstraction, over lwip. See, for example, the damage they cause with #2987: it is neither obvious nor documented that espconn_gethostbyname passes the espconn structure as the callback argument. We should just be calling dns_gethostbyname ourselves and passing the appropriate lua object to the callback.

Am I missing something and espconn is actually useful? If not, I think I will propose that we attempt to excise it from our tree.

The text was updated successfully, but these errors were encountered:

nwf mentioned this issue

Get rid of app/mbedtls/app/lwIPSocket.c #3005

Closed

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          Remove unused espconn code, take 1

5c61a9a

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          De-orbit espconn_gethostbyname

7e84d1c

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf mentioned this issue

WIP: Espconn delenda est #3006

Closed

4 tasks

nwf mentioned this issue

net_info module - ping function #2854

Merged

4 tasks

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

9941e79

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

0249b33

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

6c1d97e

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

0d5ca1e

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

1e16222

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

abeee5c

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

78ab966

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

b965e4f

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

deceb3a

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

47258e9

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

bebe499

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

82a01cf

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

d648ae7

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

73b502c

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

041305f

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

7ac768d

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

90344e9

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

a9230c9

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf mentioned this issue

Networking rampage and accumulated fixes #3060

Merged

4 tasks

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: remove unused espconn code, take 1

b7ca96b

This is the easiest part of nodemcu#3004 .
It removes a bunch of functions that were never called in our tree.

nwf added a commit to nwf/nodemcu-firmware that referenced this issue


          espconn: De-orbit espconn_gethostbyname

c4e3e21

Further work on nodemcu#3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

nwf added a commit that referenced this issue


          Networking rampage and accumulated fixes (#3060)

f5aa0af

* espconn: remove unused espconn code, take 1

This is the easiest part of #3004 .
It removes a bunch of functions that were never called in our tree.

* espconn: De-orbit espconn_gethostbyname

Further work on #3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

* espconn: remove scary global pktinfo

A write-only global!  How about that.

* net: remove deprecated methods

All the TLS stuff moved over there a long time ago, and
net_createUDPSocket should just do what it says on the tin.

* espconn_secure: remove ESPCONN_SERVER support

We can barely function as a TLS client; being a TLS server seems like a
real stretch.  This code was never called from Lua anyway.

* espconn_secure: more code removal

* espconn_secure: simplify ssl options structure

There is nothing "ssl_packet" about this structure.  Get rid of the
terrifying "pbuffer" pointer.

Squash two structure types together and eliminate an unused field.

* espconn_secure: refactor mbedtls_msg_info_load

Split out espconn_mbedtls_parse, which we can use as part of our effort
towards addressing #3032

* espconn_secure: introduce TLS cert/key callbacks

The new feature part of #3032
Subsequent work will remove the old mechanism.

* tls: add deprecation warnings

* luacheck: net.ifinfo is a thing now

* tls: remove use of espconn->reverse

* mqtt: stop using espconn->reverse

Instead, just place the espconn structure itself at the top of the user
data.  This enlarges the structure somewhat but removes one more layer
of dynamic heap usage and NULL checks.

While here, simplify the code a bit.

* mqtt: remove redundant pointer to connect_info

Everywhere we have the mqtt_state_t we also have the lmqtt_userdata.

* mqtt: doc fixes

* mqtt: note bug

* tls: allow :on(...,nil) to unregister a callback

marcelstoer pushed a commit that referenced this issue


          Networking rampage and accumulated fixes (#3060)

af426d0

* espconn: remove unused espconn code, take 1

This is the easiest part of #3004 .
It removes a bunch of functions that were never called in our tree.

* espconn: De-orbit espconn_gethostbyname

Further work on #3004

While here, remove `mqtt`'s charming DNS-retry logic (which is neither
shared with nor duplicated in other modules) and update its :connect()
return value behavior and documentation.

* espconn: remove scary global pktinfo

A write-only global!  How about that.

* net: remove deprecated methods

All the TLS stuff moved over there a long time ago, and
net_createUDPSocket should just do what it says on the tin.

* espconn_secure: remove ESPCONN_SERVER support

We can barely function as a TLS client; being a TLS server seems like a
real stretch.  This code was never called from Lua anyway.

* espconn_secure: more code removal

* espconn_secure: simplify ssl options structure

There is nothing "ssl_packet" about this structure.  Get rid of the
terrifying "pbuffer" pointer.

Squash two structure types together and eliminate an unused field.

* espconn_secure: refactor mbedtls_msg_info_load

Split out espconn_mbedtls_parse, which we can use as part of our effort
towards addressing #3032

* espconn_secure: introduce TLS cert/key callbacks

The new feature part of #3032
Subsequent work will remove the old mechanism.

* tls: add deprecation warnings

* luacheck: net.ifinfo is a thing now

* tls: remove use of espconn->reverse

* mqtt: stop using espconn->reverse

Instead, just place the espconn structure itself at the top of the user
data.  This enlarges the structure somewhat but removes one more layer
of dynamic heap usage and NULL checks.

While here, simplify the code a bit.

* mqtt: remove redundant pointer to connect_info

Everywhere we have the mqtt_state_t we also have the lmqtt_userdata.

* mqtt: doc fixes

* mqtt: note bug

* tls: allow :on(...,nil) to unregister a callback

stale bot commented Jan 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

Member Author

nwf commented Jan 31, 2021

Still true, sadly.

stale bot removed the stale label

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

Member

HHHartmann commented Apr 19, 2022

Is it still true?

stale bot removed the stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment