More, but more subdued, rampaging for next release #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHHartmann
reviewed
Apr 18, 2020
The additional reporting, while nice, prevents the use of mispec on integer-only builds
Prefer print everywhere.
IMHO, it's generally good style to register the callbacks first.
Seems more polite than quietly accepting other types as nil.
Removes yet another unchecked allocation point in our C libraries. While here, fix potential reference leaks on error paths Also while here, remove some stale documentation. There can be as many DNS requests in flight as LwIP has room for in its table (DNS_TABLE_SIZE, which defaults to 4).
Because the old API was inactive, we were setting MBEDTLS_SSL_VERIFY_NONE even after we'd parsed the certificate. tls tests now include a deliberate certificate mismatch; this was discovered by moving the mqtt tests over to the new API.
|
Sorry about that; pushed the wrong set of commits. D'oh. Anyway, here's the correct set with @HHHartmann's suggestion in place. I'd like to merge these this weekend, so if I don't hear any objections by this evening I'll click my own button and will deal with any fallout. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch rather than formaster.docs/*.This is another round of minor scattered changes throughout the tree. I'd like at least
tls: fix new verification APIto land because it corrects an embarrassing error on my part.I'd appreciate someone glancing over this, especially some of the more obscure Lua bits (
__metatable,LUA_GCSTOP, ...).