fix #2565 by inverting the grb2hsv argcheck condition #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HHHartmann I took the liberty of adding you as a reviewer as you the had the issue self-assigned back then. |
marcelstoer
pushed a commit
that referenced
this pull request
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2565.
Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
devbranch rather than formaster.docs/*.The arg check condition for
color_utils.grb2hsv(), which was intended to protect against greyscale values, did opposite by only allowing greyscale values.After inverting check condition, I was able to use the function.