Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3089 - update hook after updating gpio bits #3091

Merged
merged 1 commit into from
May 10, 2020

Conversation

galjonsfigur
Copy link
Member

Fixes #3089

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

This little patch should fix problem that occurs when modules like rotary or softuart hooks to gpio ISR more than one time.

If anyone could test if using more than one rotary encoder works with this patch (as this also should affect rotary module and I think without this patch only the first registered encoder would work) I would be thankful.

@marcelstoer marcelstoer added this to the Next release milestone May 8, 2020
@marcelstoer marcelstoer merged commit 2e58471 into nodemcu:dev May 10, 2020
vsky279 pushed a commit to vsky279/nodemcu-firmware that referenced this pull request May 23, 2020
marcelstoer pushed a commit that referenced this pull request Jun 9, 2020
@galjonsfigur galjonsfigur deleted the dev-platform-isr-fix branch August 30, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platform_gpio_register_intr_hook does not update interrupt hook pins
3 participants