fix a memory leak in ws2812_buffer_shift #3157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a memory leak in ws2812_buffer_shift by freeing the same amount of bytes we allocated before
Fixes #<GitHub-issue-number>.
Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
dev
branch rather than formaster
.docs/*
.Memory was allocated with
luaM_malloc(L, sizeof(ws2812_buffer_shift_prepare) + shift_len);
but freed with
luaM_free(L, prepare);
this caused a leak by shift_len bytes per call.The code I used to test with:
This caused a leak of 40 bytes per call before this commit, while after the numbers are stable.