Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BME280 Lua module - (config[3] & 0xFC) | BME280_FORCED_MODE workaround bug fix #3325

Merged
merged 1 commit into from
Nov 11, 2020
Merged

BME280 Lua module - (config[3] & 0xFC) | BME280_FORCED_MODE workaround bug fix #3325

merged 1 commit into from
Nov 11, 2020

Conversation

vsky279
Copy link
Contributor

@vsky279 vsky279 commented Nov 8, 2020

Fixes #3323.

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

Fixes the workaround calculation of (config[3] & 0xFC) | BME280_FORCED_MODE by formula 4*math_floor(self._config[3]:byte(1)/4)+ 1 where a multiplication back by 4 (shl 2) was missing.

@marcelstoer marcelstoer added this to the Next release milestone Nov 11, 2020
@nwf nwf merged commit d279ba2 into nodemcu:dev Nov 11, 2020
@vsky279 vsky279 deleted the c_bme280fix branch November 12, 2020 22:22
vsky279 added a commit to vsky279/nodemcu-firmware that referenced this pull request Nov 21, 2020
@vsky279
BME280 Lua module - (config[3] & 0xFC) | BME280_FORCED_MODE workaro…
bdfc180 
…und bug fix (nodemcu#3325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwf nwf nwf approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@vsky279 @nwf @marcelstoer