Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref to latest version of the action #18

Merged
merged 2 commits into from
May 8, 2021

Conversation

avinash-vllbh
Copy link
Contributor

Github actions require uses syntax to be in the following format - {owner}/{repo}@{ref}.

Without it the workflow syntax is determined to be invalid and will raise the following error expected format {org}/{repo}[/path]@ref.

Github actions require `uses` syntax to be in the following format - `{owner}/{repo}@{ref}`.

Without it the workflow syntax is determined to be invalid and will raise the following error `expected format {org}/{repo}[/path]@ref`.
@avinash-vllbh
Copy link
Contributor Author

@lastthyme thanks for the approval.

@jasonkarns if it looks good, can you merge this PR?

@jasonkarns
Copy link
Member

Can you link to an example that shows this error? This version suffix is supposed to be optional, and is indeed still documented as such.

@jasonkarns
Copy link
Member

I've validated that github has changed their behavior regarding omitting action versions. (And I have an open support ticket with them.)

Until then, I would still like to merge this, but it needs to be updated to use main instead of master.

@avinash-vllbh
Copy link
Contributor Author

I've validated that github has changed their behavior regarding omitting action versions. (And I have an open support ticket with them.)

Until then, I would still like to merge this, but it needs to be updated to use main instead of master.

Thanks @jasonkarns I updated ref to say main.

@jasonkarns jasonkarns merged commit a28f88a into nodenv:main May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants