feat:(src!): Make the loadSpecFromCluster setting true by default #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING_CHANGE: This changes the default value of loadClusterFromSpec to true instead of false. The motivation is that most people will want to just load the API's their cluster has access to. If they can't do that, then it does fallback to load the included spec file. This could be another investigation, to see if we really need this fallback. If not, it would get rid of a somewhat large file.
lholmquist
force-pushed
the
default-to-load-from-cluster
branch
from
307a6cc
to
ed699aa
Compare
lholmquist
changed the title
helio-frota
approved these changes
Oct 1, 2021
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING_CHANGE:
This changes the default value of loadSpecFromCluster to true instead of false. This requires a semver-major update
The motivation is that most people will want to just load the API's their cluster has access to. If they can't do that, then it does fallback to load the included spec file. This could be another investigation, to see if we really need this fallback. If not, it would get rid of a somewhat large file.