Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop maintaining a set of created circuits #363

Closed
lance opened this issue Aug 15, 2019 · 0 comments · Fixed by #365
Closed

Stop maintaining a set of created circuits #363

lance opened this issue Aug 15, 2019 · 0 comments · Fixed by #365
Assignees
@lance
Labels
enhancement good first issue ready semver-major

Comments

@lance
Copy link
Member

lance commented Aug 15, 2019

This may cause memory leaks, and since it is not required for anything within a circuit, it seems that it should exist in user land.

Ref: #350 (comment)
@lance lance self-assigned this Aug 15, 2019
lance added a commit that referenced this issue Aug 15, 2019
@lance
improvement: stop keeping a set of all circuits
4e903e6 
BREAKING CHANGE

This has been shown to cause memory leaks and can effectively
be implemented in user code.

Fixes: #363
@lance lance mentioned this issue Aug 15, 2019
Merged
lance added a commit that referenced this issue Aug 20, 2019
@lance
improvement: stop keeping a set of all circuits
52cb2c6 
BREAKING CHANGE

This has been shown to cause memory leaks and can effectively
be implemented in user code.

Fixes: #363
lance added a commit that referenced this issue Aug 20, 2019
@lance
improvement: stop keeping a set of all circuits (#365)
3b79d5e 
BREAKING CHANGE

This has been shown to cause memory leaks and can effectively
be implemented in user code.

Fixes: #363
@pacostas pacostas mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance lance

Labels
enhancement good first issue ready semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement: stop keeping a set of all circuits nodeshift/opossum
1 participant
@lance