Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove factory function and expose constrctor #364

Closed
lance opened this issue Aug 15, 2019 · 0 comments · Fixed by #366
Closed

Remove factory function and expose constrctor #364

lance opened this issue Aug 15, 2019 · 0 comments · Fixed by #366
Assignees
@lance
Labels
enhancement needs-review semver-major

Comments

@lance
Copy link
Member

lance commented Aug 15, 2019

With the move of many things to user space, the factory function no longer serves a purpose. It should be removed and the CircuitBreaker constructor should be exposed.

Ref: #350 (comment)
@lance lance self-assigned this Aug 15, 2019
lance added a commit that referenced this issue Aug 15, 2019
@lance
improvement: expose CircuitBreaker ctor
47e0563 
BREAKING CHANGE

Instead of requiring the use of a factory function, which has
no real purpose other than introducing a layer of indirection,
we should really just be exposing the CircuitBreaker constructor
function.

Fixes: #364
@lance lance mentioned this issue Aug 15, 2019
Merged
lance added a commit that referenced this issue Aug 20, 2019
@lance
improvement: expose CircuitBreaker ctor (#366)
7088da7 
* improvement: expose CircuitBreaker ctor

BREAKING CHANGE

Instead of requiring the use of a factory function, which has
no real purpose other than introducing a layer of indirection,
we should really just be exposing the CircuitBreaker constructor
function.

Fixes: #364

* squash: fix linting issues caused by making some lines too long
@pacostas pacostas mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance lance

Labels
enhancement needs-review semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement: expose CircuitBreaker ctor nodeshift/opossum
1 participant
@lance