feat: allow multiple circuits to aggregate stats #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lholmquist
reviewed
Feb 5, 2018
examples/hystrix/app.js
Outdated
|
|
||
| hystrixStats.getHystrixStream().pipe(response); | ||
| }); | ||
| app.use('/hystrix.stream', require('./hystrix-stream.js')(circuitBreaker)); |
There was a problem hiding this comment.
i don't think you need the .js extension here
lholmquist
reviewed
Feb 5, 2018
index.js
Outdated
| @@ -45,6 +45,8 @@ | |||
| */ | |||
| circuitBreaker.promisify = require('./lib/promisify'); | |||
|
|
|||
| circuitBreaker.stats = require('./lib/hystrix-stats.js').stream; | |||
There was a problem hiding this comment.
same as other comment about the extension
Closed
It was a regresssion...
Not sure how ideal this fix is, but now that we are piping all event data for all circuits through a single `TransformStream`, a LOT of events are being listened for.
lance
force-pushed
the
125-aggregated-hystrix-stats
branch
from
7b2c97d
to
3755cb6
Compare
ghost
removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user creates multiple circuits in the same process, they should aggregate
their stats in the Hystrix stream.
Fixes: #125
Ref: #124
Connects: #125